Command Prompt Help

[burn2destroy]

Well, I think I got this script right for my OS, its to make a new user or login.

@echo off
:start
cls
echo Have you got an account? (Y/N)
set /p yn=
IF %yn% == N GOTO 1
IF %yn% == n GOTO 1
IF %yn% == Y GOTO 2
IF %yn% == y GOTO 2

:1
cls
echo Please type your new account name.

set /p username=
md %username%
cls
echo loading
ping localhose -n 2 > nul
cls
echo loading.
ping localhose -n 2 > nul
cls
echo loading..
ping localhose -n 2 > nul
cls
echo loading…
ping localhose -n 2 > nul
cls
echo Enjoy!
cls
PAUSE > nul
goto start
exit

:2
cls
set /p login=Username:
if not exist %login% goto start
:logged in
cls
echo You are logged in.
PAUSE > nul

Does it look right?

 

[Ð88]

it's been ages since i've done any shell scripting so i can't comment on whether it's correct or not but one thing I noticed immediately is that there is no handle for improper user inputs