If you have a decent specced machine, I would go with Vista, because of DX10 support, and also because it's just works like it should now.
I'm running the 64 bit edition (I would recommend going with 64 bit over 32 bit), and I've had zero problems with it. I don't think I could go back to XP.